Closed yixuy closed 2 years ago
Merging #806 (ef63f2e) into develop (1be5fce) will not change coverage. The diff coverage is
n/a
.:exclamation: Current head ef63f2e differs from pull request most recent head 7a51801. Consider uploading reports for the commit 7a51801 to get more accurate results
@@ Coverage Diff @@
## develop #806 +/- ##
========================================
Coverage 55.11% 55.11%
========================================
Files 293 293
Lines 18855 18855
========================================
Hits 10391 10391
Misses 8464 8464
Impacted Files | Coverage Δ | |
---|---|---|
dataprep/eda/correlation/compute/overview.py | 98.49% <0.00%> (-0.76%) |
:arrow_down: |
dataprep/eda/diff/render.py | 91.33% <0.00%> (+0.36%) |
:arrow_up: |
Continue to review full report at Codecov.
Legend - Click here to learn more
Δ = absolute <relative> (impact)
,ø = not affected
,? = missing data
Powered by Codecov. Last update 75820ab...7a51801. Read the comment docs.
Description
Please include a summary of the change and which issue is fixed. Please also include relevant motivation and context. List any dependencies that are required for this change.![7CF261F5-187F-4B56-88A9-EC83CDB1C4A7](https://user-images.githubusercontent.com/52525616/153345856-9e54dffb-4f70-41dc-b586-7d6645e00dec.jpeg)
The PR fix the bug when the user did not select any column in the columns section and pressed the OK button and the backend error will show up
How Has This Been Tested?
Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration
Python 3.9.7 for Mac M1 chip MacOS Monterey 12.2
Snapshots:
The error will not show under the table and will alert for user to select the column.
Include snapshots for easier review.![image](https://user-images.githubusercontent.com/52525616/153346488-96b6f13f-298a-40ea-9a5b-2f45f86dbcd0.png)
Checklist: