sfu-db / dataprep

Open-source low code data preparation library in python. Collect, clean and visualization your data in python with a few lines of code.
http://dataprep.ai
MIT License
1.99k stars 203 forks source link

Fix when minute and second of lat and long are 60 #811

Closed yixuy closed 2 years ago

yixuy commented 2 years ago

Description

Please include a summary of the change and which issue is fixed. Please also include relevant motivation and context. List any dependencies that are required for this change.

Cleaning latitude and longitude fail (outputs NaN) when cleaning degrees, minutes, seconds (DMS) coordinates if minutes or seconds equals 60.

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration

As issue #805 demonstrate: Cleaning latitude and longitude DMS coordinates outputs NaN when minutes or seconds equal 60

Snapshots:

Include snapshots for easier review.

image

The situation of the second and minute has been corrected.

Checklist:

codecov[bot] commented 2 years ago

Codecov Report

Merging #811 (d0da182) into develop (1be5fce) will increase coverage by 0.00%. The diff coverage is n/a.

:exclamation: Current head d0da182 differs from pull request most recent head 2b960d7. Consider uploading reports for the commit 2b960d7 to get more accurate results

Impacted file tree graph

@@           Coverage Diff            @@
##           develop     #811   +/-   ##
========================================
  Coverage    55.11%   55.11%           
========================================
  Files          293      293           
  Lines        18855    18855           
========================================
+ Hits         10391    10392    +1     
+ Misses        8464     8463    -1     
Impacted Files Coverage Δ
dataprep/clean/clean_lat_long.py 86.22% <ø> (ø)
dataprep/eda/correlation/compute/overview.py 99.24% <0.00%> (ø)
dataprep/eda/distribution/compute/overview.py 94.05% <0.00%> (+0.54%) :arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 4c3b231...2b960d7. Read the comment docs.