sfu-db / dataprep

Open-source low code data preparation library in python. Collect, clean and visualization your data in python with a few lines of code.
http://dataprep.ai
MIT License
1.99k stars 203 forks source link

fix(clean): fix the bug of am, pm #812

Closed qidanrui closed 2 years ago

qidanrui commented 2 years ago

Description

Fix the bug proposed in #749

How Has This Been Tested?

Please see the snapshots

Snapshots:

Include snapshots for easier review. Screen Shot 2022-02-14 at 10 55 59 AM

In the same time, we keep the origin test cases valid. Screen Shot 2022-02-14 at 10 56 40 AM

Checklist:

codecov[bot] commented 2 years ago

Codecov Report

Merging #812 (99ed014) into develop (1be5fce) will increase coverage by 0.02%. The diff coverage is 81.25%.

Impacted file tree graph

@@             Coverage Diff             @@
##           develop     #812      +/-   ##
===========================================
+ Coverage    55.11%   55.13%   +0.02%     
===========================================
  Files          293      293              
  Lines        18855    18870      +15     
===========================================
+ Hits         10391    10404      +13     
- Misses        8464     8466       +2     
Impacted Files Coverage Δ
dataprep/clean/clean_date_utils.py 76.84% <81.25%> (+0.25%) :arrow_up:
dataprep/eda/correlation/compute/overview.py 100.00% <0.00%> (+0.75%) :arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update d00d2eb...99ed014. Read the comment docs.