sfu-db / dataprep

Open-source low code data preparation library in python. Collect, clean and visualization your data in python with a few lines of code.
http://dataprep.ai
MIT License
2.03k stars 204 forks source link

821 redundant code of clean_lat_long #866

Closed yixuy closed 2 years ago

yixuy commented 2 years ago

Description

Please include a summary of the change and which issue is fixed. Please also include relevant motivation and context. List any dependencies that are required for this change.

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration

Part of clean_lat_long code is redundant

Snapshots:

image

Include snapshots for easier review.

Checklist:

codecov[bot] commented 2 years ago

Codecov Report

Merging #866 (f527697) into develop (482ca40) will decrease coverage by 0.40%. The diff coverage is 37.69%.

:exclamation: Current head f527697 differs from pull request most recent head 002e949. Consider uploading reports for the commit 002e949 to get more accurate results

@@             Coverage Diff             @@
##           develop     #866      +/-   ##
===========================================
- Coverage    55.32%   54.91%   -0.41%     
===========================================
  Files          293      293              
  Lines        18993    19480     +487     
===========================================
+ Hits         10507    10698     +191     
- Misses        8486     8782     +296     
Impacted Files Coverage Δ
dataprep/clean/__init__.py 100.00% <ø> (ø)
dataprep/clean/clean_ad_nrt.py 25.58% <ø> (ø)
dataprep/clean/clean_al_nipt.py 25.58% <ø> (ø)
dataprep/clean/clean_ar_cbu.py 20.00% <ø> (ø)
dataprep/clean/clean_ar_cuit.py 23.91% <ø> (ø)
dataprep/clean/clean_ar_dni.py 23.91% <ø> (ø)
dataprep/clean/clean_at_uid.py 25.58% <ø> (ø)
dataprep/clean/clean_at_vnr.py 25.58% <ø> (ø)
dataprep/clean/clean_au_acn.py 23.40% <ø> (ø)
dataprep/clean/clean_be_iban.py 23.40% <ø> (ø)
... and 155 more

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update c493349...002e949. Read the comment docs.