sfu-db / dataprep

Open-source low code data preparation library in python. Collect, clean and visualization your data in python with a few lines of code.
http://dataprep.ai
MIT License
2.03k stars 204 forks source link

Fix # 876 Add more countries in the clean_phone #884

Closed yixuy closed 2 years ago

yixuy commented 2 years ago

Description

Please include a summary of the change and which issue is fixed. Please also include relevant motivation and context. List any dependencies that are required for this change.

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration

It is described as #876

Snapshots:

Include snapshots for easier review. image

Checklist:

codecov[bot] commented 2 years ago

Codecov Report

Merging #884 (e876d21) into develop (fbf0676) will decrease coverage by 0.02%. The diff coverage is 89.37%.

:exclamation: Current head e876d21 differs from pull request most recent head a27587e. Consider uploading reports for the commit a27587e to get more accurate results

@@             Coverage Diff             @@
##           develop     #884      +/-   ##
===========================================
- Coverage    56.06%   56.04%   -0.03%     
===========================================
  Files          314      314              
  Lines        20451    20392      -59     
===========================================
- Hits         11466    11428      -38     
+ Misses        8985     8964      -21     
Impacted Files Coverage Δ
dataprep/tests/eda/test_create_db_report.py 100.00% <ø> (ø)
...e_db_report/pystache_models/pystache_constraint.py 40.00% <40.00%> (ø)
...aprep/eda/create_db_report/db_models/constraint.py 57.89% <57.89%> (ø)
..._db_report/pystache_models/pystache_table_index.py 77.77% <77.77%> (ø)
...db_report/pystache_models/pystache_table_column.py 81.25% <81.25%> (ø)
...prep/eda/create_db_report/db_models/table_index.py 83.33% <83.33%> (ø)
...rep/eda/create_db_report/db_models/table_column.py 90.24% <90.24%> (ø)
dataprep/eda/create_db_report/views/constraint.py 92.30% <92.30%> (ø)
...ataprep/eda/create_db_report/db_models/database.py 94.44% <94.44%> (ø)
dataprep/eda/create_db_report/db_models/table.py 94.54% <94.54%> (ø)
... and 15 more

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 356cab0...a27587e. Read the comment docs.