Closed schellenb closed 2 years ago
schellenb
commented
2 years ago I've encountered the same problem with a third poem - a search for "Indulgent Nature" (with or without qtn marks) does NOT turn up the poem "Indulgent Nature to each kind bestows," but it DOES turn up the poem "Indulgent God, whose bounteous care." So it doesn't seem to be an issue of the search string being too short.
ubermichael
commented
2 years ago These poems were not included in the search results because the code only considered poems with an author. I've corrected the code to account for it and will update the site soon.
schellenb
commented
2 years ago Thanks, Michael. The poem searches seem to be working well now.
Best, Betty
From: Michael Joyce @.> Sent: Wednesday, April 13, 2022 11:23 AM To: sfu-dhil/mvm @.> Cc: Betty Schellenberg @.>; Author @.> Subject: Re: [sfu-dhil/mvm] Search function for poems (Issue #169)
These poems were not included in the search results because the code only considered poems with an author. I've corrected the code to account for it and will update the site soon.
- Reply to this email directly, view it on GitHubhttps://github.com/sfu-dhil/mvm/issues/169#issuecomment-1098335562, or unsubscribehttps://github.com/notifications/unsubscribe-auth/ARU2SHKQV2AEH6LAX7XKH53VE4D6ZANCNFSM5Q5NSLWA. You are receiving this because you authored the thread.Message ID: @.***>
What isn’t working as expected on the website?
Some poems don't turn up via searches of keywords from first line or via phrases from first line in qtn marks.
If you encountered an error message, please copy the relevant details or take a screenshot and paste it below.
NA
What is the URL of the page where you encountered the bug?
https://dhil.lib.sfu.ca/mvm/content/
What steps did you take before you encountered the bug?
What browser, operating system, and device were you using when you encountered the error?
Firefox on my PC
Additional information
Some poem searches are working, so I haven't figured out how to tell which ones are not.