search

sfu-dhil / mvm

GNU General Public License v2.0
0 stars 3 forks source link

"hiding" manuscripts #94

Closed schellenb closed 3 years ago

schellenb commented 3 years ago

A question I meant to ask Joey this afternoon: we are deleting some entries of databases which we have no likelihood of seeing or getting adequate information on. However, there are others that I am still hoping to see in the not-too-distant future, especially at the Beinecke Library. Is there any reason why I shouldn't keep these on the database but not designate them as "complete," so that they stay hidden as drafts even after the site goes public?

joeytakeda commented 3 years ago

Depends on what the goal is for these items. One solution, as you said, is to hide manuscripts from public users on the listing pages etc. That's @ubermichael's domain, though, so I'll let him address how complicated that might be to implement.

Another solution is to show all of the manuscripts to everyone, but the ones that are marked as not complete could have some special display that alerts the user that the entry is incomplete (maybe a draft watermark background or a little notice somewhere saying "Note: This manuscript entry is incomplete" or some such). That way, even if an entry never does becomes "complete," there's still some record of its existence on the site.

ubermichael commented 3 years ago

The two options (hiding some manuscripts from view or displaying a message that they are incomplete) are the same amount of work. And that's not a lot of work to be done.

I'll work on this in the next few days, going with the hidden option unless I hear otherwise.

joeytakeda commented 3 years ago

Regardless of the option, though, there will need to be interface work to denote whether or not the the manuscript is in draft (both on the manuscript page and anywhere that it’s listed). That might be a big red banner or a watermark or a different border or something else entirely.

That said, as far as I understand it, If the draft manuscripts aren’t hidden from public view, then this is just something that can be dealt with at an interface level.

ubermichael commented 3 years ago

At a minimum there will need to be a new field, so some change to the database is required.

schellenb commented 3 years ago

Hi Michael,

Thanks for the heads-up. Can I just confirm that:

Assuming that is the case, I think the hidden option is best for now.

Best, Betty

Betty A. Schellenberg, PhD, FRHistS Professor of English Simon Fraser University Burnaby BC Canada V5A 1S6 schellen@sfu.ca 778-782-3136 www.cambridge.org/9781107128163http://www.cambridge.org/9781107128163

From: Michael Joyce notifications@github.com Sent: Tuesday, January 26, 2021 11:50 AM To: sfu-dhil/mvm mvm@noreply.github.com Cc: Betty Schellenberg schellen@sfu.ca; Author author@noreply.github.com Subject: Re: [sfu-dhil/mvm] "hiding" manuscripts (#94)

The two options (hiding some manuscripts from view or displaying a message that they are incomplete) are the same amount of work. And that's not a lot of work to be done.

I'll work on this in the next few days, going with the hidden option unless I hear otherwise.

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHubhttps://github.com/sfu-dhil/mvm/issues/94#issuecomment-767775361, or unsubscribehttps://github.com/notifications/unsubscribe-auth/ARU2SHP5CHJJWZUGUEF2BYDS34J4RANCNFSM4WNYFTRQ.

ubermichael commented 3 years ago

The manuscript new and edit forms have two "Save As..." buttons. The "Save as Draft" button marks the manuscript as incomplete in the database. We can hide those incomplete manuscripts from the public view but let them be visible to people who have logged in. The "Save as Complete" button marks the manuscript as complete and we can make those complete manuscripts public.

Right now there are no complete manuscripts in the database.

joeytakeda commented 3 years ago

Just to keep this up to date: draft manuscripts now have a little badge stating that they are in draft.

schellenb commented 3 years ago

Yes, I did notice that. Informative but not intrusive. Thanks. B.

From: Joey Takeda notifications@github.com Sent: Monday, February 8, 2021 11:57 AM To: sfu-dhil/mvm mvm@noreply.github.com Cc: Betty Schellenberg schellen@sfu.ca; Author author@noreply.github.com Subject: Re: [sfu-dhil/mvm] "hiding" manuscripts (#94)

Just to keep this up to date: draft manuscripts now have a little badge stating that they are in draft.

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHubhttps://github.com/sfu-dhil/mvm/issues/94#issuecomment-775391757, or unsubscribehttps://github.com/notifications/unsubscribe-auth/ARU2SHJ4OJRO4MRXTDXWGCDS6A4MVANCNFSM4WNYFTRQ.

ubermichael commented 3 years ago

Draft vs. complete is sufficient and there's no need to hide the drafts.