Changes to fix duplication of text

[ccolliga]

I made changes to these pages as text was duplicated. You can see the problem on these pages on the Wilde site. But I am not sure I have kept all the right tags. Does this look okay to you? If so, I will change the rest of the report pages in the same way.

[ccolliga]

Hi Michael,

My aim is to get the heading and the paragraph above the horizontal line, as that is the format for most of the other pages. See for example below.

https://dhil.lib.sfu.ca/wilde/source.html

My aim is then to have the list of languages below the horizontal line.

This will be the same layout I apply for the other report pages as well.

Best, Colette

Colette Colligan, Professor of English

Simon Fraser University, Canada

Resident Fellow, Paris Institute of Advanced Studies (2019-2020)

---

De : Michael Joyce notifications@github.com Envoyé : mercredi 8 juillet 2020 22:33 À : sfu-dhil/wilde Cc : Colette Colligan; Author Objet : Re: [sfu-dhil/wilde] Changes to fix duplication of text (#73)

@ubermichael commented on this pull request.

---

In language-nocache.htmlhttps://github.com/sfu-dhil/wilde/pull/73#discussion_r451809251:

       <p> Select one of the languages below to discover news reports on Wilde's trials published in that language. The number next to each language indicates the number of reports published in that language. </p>

This would put everything into the page header, above the horizontal line. I don't think that's what you want. This would put Browse by Language in the header and the paragraph and list of languages below the horizontal line.

<?xml version="1.0" encoding="UTF-8"?> <div xmlns="http://www.w3.org/1999/xhtml" data-template="templates:surround" data-template-with="templates/page.html" data-template-at="content">

Browse by Language

Select one of the languages below to discover news reports on Wilde's trials published in that language. The number next to each language indicates the number of reports published in that language.

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHubhttps://github.com/sfu-dhil/wilde/pull/73#pullrequestreview-445108252, or unsubscribehttps://github.com/notifications/unsubscribe-auth/AO5E5AOKYD2HQA6WNYHOK7DR2TJ3LANCNFSM4OU5PCSA.

[ubermichael]

I see. In that case the full markup would look something like this:

<?xml version="1.0" encoding="UTF-8"?>
<div xmlns="http://www.w3.org/1999/xhtml" data-template="templates:surround"
    data-template-with="templates/page.html" data-template-at="content">
    <div class="row">
        <div class="page-header">
            <h1>PAGE TITLE</h1>
            <p>Descriptive text.</p>
        </div>
    </div>
    <div class="row">
        <div class="col-md-12">
            <div data-template="app:browse-language"/>
        </div>
    </div>
</div>

The divs with class=row and class=col-md-12 are important to make sure the margins line up properly. The horizontal line will appear between the descriptive text and the list of languages.

[ccolliga]

Thanks for the template!

The good news is that I am getting the hang of github.

Colette Colligan, Professor of English

Simon Fraser University, Canada

Resident Fellow, Paris Institute of Advanced Studies (2019-2020)

---

De : Michael Joyce notifications@github.com Envoyé : mercredi 8 juillet 2020 23:06 À : sfu-dhil/wilde Cc : Colette Colligan; Author Objet : Re: [sfu-dhil/wilde] Changes to fix duplication of text (#73)

I see. In that case the full markup would look something like this:

<?xml version="1.0" encoding="UTF-8"?> <div xmlns="http://www.w3.org/1999/xhtml" data-template="templates:surround" data-template-with="templates/page.html" data-template-at="content">

PAGE TITLE

Descriptive text.

<div class="row">
    <div class="col-md-12">
        <div data-template="app:browse-language"/>
    </div>
</div>