Information obscured on some pages

[ccolliga]

Describe the bug I just noticed that the number count is obscured in some of the boxes on this page, and perhaps others like it.

To Reproduce Steps to reproduce the behavior:

1. Go to '...' Reports
2. Click on '....' Sources
3. Scroll down to '....' First box under institutions, for example
4. See error

Expected behavior I expect to see the number count on the page.

Screenshots If applicable, add screenshots to help explain your problem.

Desktop (please complete the following information):

• OS: [e.g. iOS] MacOS Mojave
• Browser [e.g. chrome, safari] Chrome
• Version [e.g. 22]

Additional context Add any other context about the problem here.

[joeytakeda]

Since there are a number of lengths that the titles that those boxes can be (i.e. "READEX" vs "Archives Départementales ..."), my suggestion is that we simply fix the height of the heading to two lines of text. If the heading exceeds that, then it truncates it with ellipses.

The other advantage to this approach is that the text in the boxes line up nicely, so the numbers and the headings are always in a consistent place:

This change would apply everywhere, though, so you'd get the same behaviour in the grid of newspapers. There are only a handle of newspapers that have titles that exceed 2 lines, but if that's an issue, we could set the limit to three lines of text. That would mean fewer ellipses in the headings, but we'd have to increase the tile's height a bit.

What do you think?

[ccolliga]

Hi Joey,

I think your solution sounds good. Thanks!

Dr. Colette Colligan, Professor of English

Simon Fraser University, Canada

Resident Fellow, Paris Institute of Advanced Studies (2019-2020)

---

De : Joey Takeda notifications@github.com Envoyé : mercredi 17 février 2021 20:17 À : sfu-dhil/wilde Cc : Colette Colligan; Author Objet : Re: [sfu-dhil/wilde] Information obscured on some pages (#99)

Since there are a number of lengths that the titles that those boxes can be (i.e. "READEX" vs "Archives Départementales ..."), my suggestion is that we simply fix the height of the heading to two lines of text. If the heading exceeds that, then it truncates it with ellipses.

The other advantage to this approach is that the text in the boxes line up nicely, so the numbers and the headings are always in a consistent place:

[Screen Shot 2021-02-17 at 10 37 16 AM]https://user-images.githubusercontent.com/17664763/108253189-5ab19380-710e-11eb-9fb1-56672c76ae23.png

[https://user-images.githubusercontent.com/17664763/108253189-5ab19380-710e-11eb-9fb1-56672c76ae23.png]

This change would apply everywhere, though, so you'd get the same behaviour in the grid of newspapers. There are only a handle of newspapers that have titles that exceed 2 lines, but if that's an issue, we could set the limit to three lines of text. That would mean fewer ellipses in the headings, but we'd have to increase the tile's height a bit.

What do you think?

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHubhttps://github.com/sfu-dhil/wilde/issues/99#issuecomment-780776139, or unsubscribehttps://github.com/notifications/unsubscribe-auth/AO5E5ANFU3G7HQHND2BBO6TS7QGSXANCNFSM4XYVTDIA.