search

sfu-dhil / wphp

Women's Print History Project database front end.
https://womensprinthistoryproject.com/
GNU General Public License v2.0
1 stars 8 forks source link

Updates on geo locations + author with no first/last name #208

Closed saba1995 closed 3 years ago

saba1995 commented 3 years ago

Location objects are now in the same format. I also used the {{author}} for those cases that there was either no first name or no last name.

joeytakeda commented 3 years ago

Hi @saba1995 : Is this ready for review?

saba1995 commented 3 years ago

Hi @joeytakeda, Yes it is! There is only 1 checked failed which I think is due to a new pull request from Michael. It is giving me this: continuous-integration/travis-ci/pr — The Travis CI build could not complete due to an error

joeytakeda commented 3 years ago

@ubermichael will know more about the state of the CI checks, so I'll let him address that.

But in terms of the twig, there are still some issues from the last PR that need to be fixed. Can you go through the comments from the last PR and make sure all of the comments are addressed? You can see those here: https://github.com/sfu-dhil/wphp/pull/204/files (And no need to do another pull request after: any new commits you make will show up here as well)

saba1995 commented 3 years ago

Hi @joeytakeda , It is weird I think my commits have not been pushed correctly to the github. Let me try it again.