search

sfu-dhil / wphp

Women's Print History Project database front end.
https://womensprinthistoryproject.com/
GNU General Public License v2.0
1 stars 8 forks source link

CSV export of search results doesn't include source or source ID #267

Closed kkatemoffatt closed 3 years ago

kkatemoffatt commented 3 years ago

Describe the bug Exported CSV file of search results does not include source or source ID data in the file.

To Reproduce Steps to reproduce the behavior:

  1. Go to 'Database' and click 'Search titles.'
  2. Click on 'Advanced search'
  3. Scroll down to 'Filter by source' and type in 'ESTC'
  4. Click search, and then click 'Export - CSV'.
  5. In the CSV file, there is no column for source or source ID

Expected behavior There should be a column for the source and a column for the source ID in the exported CSV file.

kkatemoffatt commented 3 years ago

Hi Michael! The new column for source / source ID in the CSV export combines all of the sources and their IDs into one column together. I'm trying to share our ESTC ID source data with a fellow scholar who is doing work on the ESTC, so I'm wondering if it's possible to split the source info into multiple columns so that I can more easily share that data? ie. a column per source and source ID, something like: SOURCE 1 / SOURCE 1 ID / SOURCE 2 / SOURCE 2 ID, etc? That way I can remove the columns with sources and IDs I don't need.

Let me know if you need any other info or if I should submit another bug report for this! Thanks so much for all of your help!

ubermichael commented 3 years ago

Hi Kate.

Sources can be multi-valued so separating the source name from the source ID isn't the right thing to do. The result would look something like

Source Name Source ID
Estc, Abc, Orlando 12456, 57a89t, bl00m

Since this is a kind of one-off issue, I can extract the information you need. Is it all titles with an ESTC Source? That should be all the titles in https://womensprinthistoryproject.com/source/2

kkatemoffatt commented 3 years ago

Hm, yeah, that wouldn’t work! Thanks for clarifying.

I need all titles that have ESTC as a source and were published from 1789 to 1799, if that’s possible? Thanks so much, Michael!

Kate

On Aug 19, 2021, at 11:01 AM, Michael Joyce @.***> wrote:



Hi Kate.

Sources can be multi-valued so separating the source name from the source ID isn't the right thing to do. The result would look something like

Source Name Source ID Estc, Abc, Orlando 12456, 57a89t, bl00m

Since this is a kind of one-off issue, I can extract the information you need. Is it all titles with an ESTC Source? That should be all the titles in https://womensprinthistoryproject.com/source/2

— You are receiving this because you were assigned. Reply to this email directly, view it on GitHubhttps://github.com/sfu-dhil/wphp/issues/267#issuecomment-902071418, or unsubscribehttps://github.com/notifications/unsubscribe-auth/ATJ3JXGI2ZHIX7VP2DYFWSTT5UX35ANCNFSM5CKZDPLA. Triage notifications on the go with GitHub Mobile for iOShttps://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675 or Androidhttps://play.google.com/store/apps/details?id=com.github.android&utm_campaign=notification-email.

ubermichael commented 3 years ago

I have created wphp-estc.csv and shared it via SFU vault. Please send me an email if you don't get the notification in the next while.