sfu-dhil / wphp

Women's Print History Project database front end.
https://womensprinthistoryproject.com/
GNU General Public License v2.0
1 stars 8 forks source link

Contributor role not shown in firm entry title tables #314

Closed kkatemoffatt closed 2 years ago

kkatemoffatt commented 2 years ago

What isn’t working as expected on the website?

When viewing a firm entry, the list of titles below the firm data has four columns: Firm Role, Title, Author, and Date. The issue is that under "Author", it's listing all of the contributors to the work - including those who were not authors, but who fall under other contributor roles, which is confusing (screenshot one—Elizabeth Newbery is a bookseller, but she looks like she's the author). We have two requests: we would like to rename that column to "Contributors", and we would like those persons listed in that column to have their contributor role listed in parentheses beside their name, like we do in the tables of title results (screenshot 2).

If you encountered an error message, please copy the relevant details or take a screenshot and paste it below.

image image

What is the URL of the page where you encountered the bug?

https://womensprinthistoryproject.com/firm/71?page=2

What steps did you take before you encountered the bug?

  1. Click "Database" in the header menu, and click "Search Firms"
  2. Type "Davies" into the search bar (no quotations) and hit search
  3. Click on ID 71, "Thomas Cadell and William Davies"
  4. Scroll down to view the title table display beneath the data table

What browser, operating system, and device were you using when you encountered the error?

Firefox, Windows 10, Desktop

Additional information

No response

ubermichael commented 2 years ago

Hi @kkatemoffatt

The original design was to show the first author in the author column. But that stopped working sometime (looks like November of last year) for reasons I don't understand.

If I fix it to show the author in the Author column (screenshot below) it makes a lot more sense. Is this a better solution to the problem? This is how Elizabeth Newbery's table would appear.

Screen Shot 2022-05-03 at 10 10 12 AM

As an aside, I think part of the confusion for Elizabeth Newbery is that she has both person and firm records and some titles refer to both.

kkatemoffatt commented 2 years ago

Thanks for following up, Michael! We would prefer to have it formatted to match the results tables in the title search, the way it's described above and shown in the screenshot (contributor names, and their role in brackets beside).

The first author fix would/does make more sense than what is currently happening, but it isn't as clear for the many titles we have with multiple authors, so we'd rather stick with what I described above. But thank you for checking!