search

sfu-dhil / wphp

Women's Print History Project database front end.
https://womensprinthistoryproject.com/
GNU General Public License v2.0
1 stars 8 forks source link

Unverified firm records not visible when not logged in #357

Closed kkatemoffatt closed 10 months ago

kkatemoffatt commented 1 year ago

What isn’t working as expected on the website?

When a user is not logged in, unverified firm records are not visible in our title records (basically: unverified firm records are hidden from the public on verified title records, specifically). We want unverified firm records linked in verified title records to be visible to the public, and we want to remove the "(unverified)" that appears beside them.

If you encountered an error message, please copy the relevant details or take a screenshot and paste it below.

N/A

What is the URL of the page where you encountered the bug?

N/A

What steps did you take before you encountered the bug?

  1. Look at this record when not logged in: https://womensprinthistoryproject.com/title/15508
  2. You can see how there are no firms attached.
  3. Look at the same record when logged in.
  4. You can see there are 8 firms attached with "(unverified)" beside their names. We want these firms to be visible, despite being unverified, and want to remove the "(unverified)."

What browser, operating system, and device were you using when you encountered the error?

Firefox, Windows 10, laptop

Additional information

N/A

andrew-gardener commented 1 year ago

@kkatemoffatt There is similar logic for unverified people (for Contributors).

Would like like it changed there as well?

andrew-gardener commented 1 year ago

Nevermind! Just got the notification for #358

kkatemoffatt commented 1 year ago

Hi Andrew! Ah, yes please! I submitted separate requests, but yes, we'd like to change both. Thanks so much!

Kate

From: Andrew Gardener @.***> Sent: August 2, 2023 1:41:28 PM To: sfu-dhil/wphp Cc: Kate Moffatt; Mention Subject: Re: [sfu-dhil/wphp] Unverified firm records not visible when not logged in (Issue #357)

@kkatemoffatthttps://github.com/kkatemoffatt There is similar logic for unverified people (for Contributors).

Would like like it changed there as well?

— Reply to this email directly, view it on GitHubhttps://github.com/sfu-dhil/wphp/issues/357#issuecomment-1662917746, or unsubscribehttps://github.com/notifications/unsubscribe-auth/ATJ3JXGF23LRWWZAWNQ74DDXTKZELANCNFSM6AAAAAA3BXTLFI. You are receiving this because you were mentioned.Message ID: @.***>