search

sfu-dis / pibench

Benchmarking framework for index structures on persistent memory
MIT License
87 stars 20 forks source link

leveldb library added #19

Closed JonghyeokPark closed 4 years ago

JonghyeokPark commented 4 years ago

The Leveldb library and wrapper functions are added. The leveldb_wrapper can be applicable for other lsm-tree based storage engine. Please see the comments in wrappers/leveldb/CMakeLists.txt

wangtzh commented 4 years ago

It seems tests are failing - any ideas?

JonghyeokPark commented 4 years ago

It seems tests are failing - any ideas?

The snappy and numa library are not prepared, It should check library existence first, and link those libraries to wrapper function.

llersch commented 4 years ago

Thanks for the contribution, I started reviewing the changes, but since there are some commits that undo initial changes, it will be confusing to read my comments.

Could you make a new Pull Request with a single commit with all changes? Then I will make my comments on the new PR and we can work together to fix the build errors.

For the future, you can use git commit --amend to edit the last commit and avoid creating new ones. Keeping a single commit per Pull Request makes it easier to review :)

JonghyeokPark commented 4 years ago

@llersch sorry for duplicate commit request, I will make a new PR.