search

sfu-dis / pibench

Benchmarking framework for index structures on persistent memory
MIT License
87 stars 20 forks source link

Leveldb wrapper added #20

Closed JonghyeokPark closed 4 years ago

JonghyeokPark commented 4 years ago

This version builds Leveldb (https://github.com/google/leveldb.git) and map the wrapper function. However, this version does not pass the clang-6.0 build test. because find_package(OpenMP) is failed.

llersch commented 4 years ago

Take a look at the changes I proposed. Remember to use git commit --amend to edit the existing comit and avoid creating a new one. There are more things to fix, but let's start slow :)

Also, the build problem is probably on our side. Don't worry about it now, I will take a look.

llersch commented 4 years ago

Just as an update. I fixed the Clang build problem, so it should pass next time the PR build is triggered. The problem was a missing dependency of libomp-dev. I added libomp5 to the Clang build in Azure Pipelines and it works now.

I am currently reading about how to better integrate LevelDB into the build. It might be better to use FetchContent instead of ExternalProject. I will let you know when I figure it out.

llersch commented 4 years ago

The PR passed the build and therefore I rebased it into the master branch. Welcome to the list of contributors :) Good job and thanks for contributing!