search

sfu-natlang / lensingwikipedia

Lensing Wikipedia is an interface to visually browse through human history as represented in Wikipedia. This the source code that runs the website:
http://lensingwikipedia.cs.sfu.ca
Other
11 stars 4 forks source link

multiple Person facets: what would happen? #138

Closed anoopsarkar closed 9 years ago

anoopsarkar commented 9 years ago

For some reason if I add multiple Person facets to the Facet view, what would happen?

Would I be able to select different entities from each of the Person facets, or would they be linked somehow via queries.js?

theq629 commented 9 years ago

I think the main facet code would handle it fine, and they would be unlinked. However, the list of facets (in index.html) is keyed on field, and storyline.js may also make that assumption. So we'd need to change that to be able to do this at all.

theq629 commented 9 years ago

In the mwhitneyrefactoring branch the list of facets is not keyed on field, so you can add duplicates easily. For example put this in frontendsettings.js for an extra person facet that the storyline will ignore:

FrontendConfig.facets.push({
  field: "person",
  title: "Person2"
});
anoopsarkar commented 9 years ago

Great. I assume this means that we can use this functionality for issue #141

Should we close this issue?

theq629 commented 9 years ago

The branch also includes the changes for #120 (which may need feedback before merging), so whatever you think about closing this issue.