Closed theq629 closed 9 years ago
I've put up the new interface in the mwhitneyrefactoring branch and my running demos. I haven't finished the facet code refactoring yet.
A major question with the current interface is how to handle entities included in the storyline view falling out of the menu as other constraints change. How does it sound if they are always added as zero-count items in the menu (similar to how the facets handle it), and then we add an explicit "no matches" message for the case where there are no events to make a storyline with since all entities don't occur under current constraints?
Yes, the solution above is consistent with how other views handle zero-counts created due to other selections. Go ahead with it. Does the new interface require facet code refactoring or is that a separate issue?
Ok, I'll work add that zero-count handling within the next few hours. The facet code refactoring doesn't matter for the interface, I'd just like to have them share code for the menu.
We don't have to wait for facet code refactoring in order to push this change to the Storyline view to master. Once you are done with zero-count handling, merge it and close this issue (and let me know).
Do we need a new issue for facet code refactoring or is it covered by an already open issue?
I was originally assuming it would be done with this issue, but since it looks like it doesn't need to be I'll start a new issue.
I've added zero-count handling and a no matches message. There is a pull request, if it looks ok.
We will remove the coupling of the storyline view with the facet view, instead adding a new dropdown menu at the top of the storyline view which allows the user to select entities to include. Additionally, the storyline with start with an initial view which is the top entry in the dropdown menu.
Original discussion from #111:
@anoopsarkar:
@theq629:
@anoopsarkar: