search

sfu-natlang / lensingwikipedia

Lensing Wikipedia is an interface to visually browse through human history as represented in Wikipedia. This the source code that runs the website:
http://lensingwikipedia.cs.sfu.ca
Other
11 stars 4 forks source link

The + button is hidden #198

Closed anoopsarkar closed 8 years ago

anoopsarkar commented 8 years ago

The + button that expands the text on the left side column to show the entire event description is currently not showing up or is transparent. One can still click on where the + should appear and it will show the entire event. Perhaps it a CSS issue?

To replicate this bug: Select Augustus from the Person facet and click to the space next to the period on the first event on the left hand panel.

anoopsarkar commented 8 years ago

I give up. I tried to put in the new glyphicons css into wikipediahistory.js and avherald.js

I added the fonts files to vendor/bootstrap/fonts

These changes are in master. Now I can't even click on the space to toggle the full description. Perhaps it does not like the combination of using "glyphicon glyphicon-plus-sign"and the use of toggleClass.

avacariu commented 8 years ago

It works fine for me (not on master, but on a branch that's derived from the latest commit to master) screenshot from 2015-08-28 13 39 05

avacariu commented 8 years ago

This is fixed in a0fa4705f1126dd83a296ffe0cca5b6855f14eee.

anoopsarkar commented 8 years ago

There is a bug in the solution to this issue. Here is how to recreate it:

  1. Go to http://lensingwikipedia.cs.sfu.ca:8080
  2. Select Muhammed from Person
  3. Select Jabal Thawr from Location
  4. Repeatedly toggle [+] to [-] and vice versa in the last event with heading 622 CE: warn. You should be able to see both [+] and [-] and also part of the description gets hidden.

It might have something to do with the line break in the middle of [+].

avacariu commented 8 years ago

It seems to work as expected for me. Clicking [+] expands the description, and [-] hides it.

anoopsarkar commented 8 years ago

In my browser (Chrome macosx) it sometimes hides the first half of the description and also shows both + and - in some cases.

avacariu commented 8 years ago

That seems like a bug in Chrome, rather than in my code. All the code does is replace the text within a tag; it doesn't touch anything else.

avacariu commented 8 years ago

Replacing the .html() with .text() doesn't seem to help, but I'll make that change anyways since it's better.

anoopsarkar commented 8 years ago

Works fine on Safari on macosx. So a Chrome issue then. I'll re-close the issue.