search

sfu-natlang / lensingwikipedia

Lensing Wikipedia is an interface to visually browse through human history as represented in Wikipedia. This the source code that runs the website:
http://lensingwikipedia.cs.sfu.ca
Other
11 stars 4 forks source link

facet counts not being updated #200

Closed anoopsarkar closed 8 years ago

anoopsarkar commented 8 years ago

Recent changes to facet handling has broken count updates.

To recreate bug with just Facet:

  1. Select any entity in Person facet
  2. Notice that the numbers do not change for the other entities. Selection is now intersection so the counts should reflect that.

To recreate bug with Storyline and Facet:

  1. Select 'Hadrian' in Person facet
  2. Select 'Hadrian' in Storyline facet
  3. Select 'Vibia Sabina' in the Storyline entity line
  4. Go back to Facet tab. The counts are clearly incorrect.
theq629 commented 8 years ago

I believe this is working properly on my demo site (http://lensingwikipedia.cs.sfu.ca:9000) now, for both facet and storyline. Please check. I'm not totally sure that the second counts bug is the same as the first bug, but most likely it is and therefore both are fixed.

anoopsarkar commented 8 years ago

Yes, it is working. Can you push this fix to master please. The main site is essentially broken without this fix.

theq629 commented 8 years ago

Ok, pushed to storyline fixes with a pull request to master.