sfuphantom / vcu-fw

Vehicle Control Unit - Firmware for the TMS570LS1227 written upon the freeRTOS v9 platform
5 stars 4 forks source link

APPS Implausibility #14

Closed jaypacamarra closed 5 months ago

jaypacamarra commented 2 years ago

According to rule from 2022 Formula SAE official rules, T.4.2.5 If an implausibility occurs between the values of the APPSs and persists for more than 100msec, the power to the (IC) electronic throttle / (EV) Motor(s) must be immediately stopped completely. (EV only) It is not necessary to Open the Shutdown Circuit, the motor controller(s) stopping the power to the Motor(s) is sufficient.

Objective Change the necessary code in the throttle task such that when an APPS implausibility (APPS1 & APPS2 differs by more than 10%) occurs, we ignore all consequent throttle commands, or set THROTTLE_AVAILABLE to false. Double-check this solution with the controls team.

jaypacamarra commented 2 years ago

Hint: You'll need to modify the logic for setting the throttle in task_throttle.c image

rafguevara14 commented 1 year ago

This should be fixed already. We should run a quick test to validate this

rafguevara14 commented 5 months ago

stale issue

rafguevara14 commented 5 months ago

firmware handles this already. see where suspend throttle is called