search

sfxcode / formkit-primevue

PrimeVue (v4, v3) support for the FormKit validation Framwork
https://sfxcode.github.io/formkit-primevue
85 stars 10 forks source link

Add intellisense types, fix reactivity issues, allow kebab-case properties #36

Closed kswzr closed 4 months ago

kswzr commented 4 months ago

Hey @sfxcode, I've although thought about using v-bind="$attrs", but then component properties could not be used in kebab-case style.

sfxcode commented 4 months ago

Hi Kevin, nice work and good point with the kebab case properties. I will look into this in the evening. Disadvantage is v-bind allows additional properties that are not part of the implementation and deleting it will prevent using them ... But in general you are right,

Greetings,

Tom

sfxcode commented 4 months ago

i do not understand the formkit folder in the src dir of your branch

kswzr commented 4 months ago

Sure, I will check that.

i do not understand the formkit folder in the src dir of your branch

You're right. That's a fault. Something gone wrong during comparison with my project, will fix that later.

Hi Kevin, nice work and good point with the kebab case properties. I will look into this in the evening. Disadvantage is v-bind allows additional properties that are not part of the implementation and deleting it will prevent using them ... But in general you are right,

Greetings,

Tom

I would suggest that we add the v-bind="$attrs" as first argument, to no loose what you have described. Also we can override then the attrs parameters with the context ones :)

sfxcode commented 4 months ago

I would suggest that we add the v-bind="$attrs" as first argument, to no loose what you have described. Also we can override then the attrs parameters with the context ones :)

Perfect, make it so ...

Greetings from Würzburg

sfxcode commented 4 months ago

Again, very cool that you take part in this project ...

kswzr commented 4 months ago

@sfxcode could review my changes, please? I've fixed all the issues caused by rebase and added the v-bind property.

I am currently seeing one task regarding the icon property. I have seen in your changelog that there are things changed by PrimeVue. Maybe you could explain that, so I can adapt it to that?

sfxcode commented 4 months ago

@sfxcode could review my changes, please? I've fixed all the issues caused by rebase and added the v-bind property.

I am currently seeing one task regarding the icon property. I have seen in your changelog that there are things changed by PrimeVue. Maybe you could explain that, so I can adapt it to that?

Done, some minor fixes, Icons on Text Field replaced by PrimeVue IconField Tried to use value instead of v-bind like it is written by formkit, but many things does not wotk and some side effects, so i reverted it.

Again, ty for your very nice work.

Given something back was also my reason do make some public repositories.

Have a great coding time,

Tom

sfxcode commented 3 months ago

Hi, one question,

have you committed with an email that is not connected to your github account?

You have made very good additions but you are not showed up in the list of comitters ....

Anyway, thanks again for supporting open source projects !

Greetings,

Tom

kswzr commented 3 months ago

Hi, one question,

have you committed with an email that is not connected to your github account?

You have made very good additions but you are not showed up in the list of comitters ....

Anyway, thanks again for supporting open source projects !

Greetings,

Tom

Yes, you're right. May I rebase those commits and change the author email?