search

sfztools / sfizz-ui

SFZ based sampler, providing AU / LV2 / PD / VST3 plugins using the sfizz library
https://sfztools.github.io/sfizz/
BSD 2-Clause "Simplified" License
44 stars 9 forks source link

Notes hanging in Reaper (in Sfizz 1.2.3) #132

Open koalastudio72 opened 8 months ago

koalastudio72 commented 8 months ago

Hi dear devs,

I just tried the new version of Sfizz 1.2.3 in my DAW. I loaded a patch of Virtual Playing Orchestra and played a little. Soon there were hanging notes. To test it, I returned to version 1.2.2. -> Loaded the same patch -> No hanging notes. To be absolutely safe I retried version 1.2.3 and there were the hanging notes again. So, I think there could be a relevant bug in 1.2.3 (perhaps in combination with Reaper). For me no larger problem, because I use 1.2.2 as long as this is fixed.

my configuration: Win 10 Pro Reaper 7.11

Nevertheless hands up for this wonderful piece of software. Thanks devs !

ousado commented 6 months ago

I experience hanging notes both in Ardour and in Bitwig, both on Linux, pretty sure this is a regression in 1.2.3.

redtide commented 6 months ago

@paulfd I let this here because I'm not sure if it's a library or plugin issue.

kporkka commented 6 months ago

Same issue, Linux/Ubuntu-clone 22.04, Reaper 7.15.

In OBS, there only is the latest version of the prepackaged deb files (in my use case), where could I find the previous ones?

Thanks!

bauermaximilian commented 6 months ago

I have the same issue - with a pretty fresh Kubuntu 23.10 64 bit installation, trying both with Ardour 7.5.0 and 8.6.0, using ALSA and the headphone jack of my integrated soundcard as audio output.

I tried with different sample rates, buffer sizes, changed my CPU frequency to "performance", nothing helped. It did made a difference whether I used the VST3 version vs. the LV2 version though - in the latter, when sliding with my left mouse button down over the piano roll in sfizz, this was enough to cause at least 4 notes to get stuck, while in the VST3 version this was only happening rather randomly (and not necessarily during "heavy load") when receiving MIDI input through Ardour. However, while the LV2 version could be "unstuck" by sending a MIDI Panic through Ardour, the VST3 version had to be completely "disabled" and reenabled to "unstuck" the notes.

I checked the MIDI signals going into sfizz using the MIDI tracer - and can confirm that all NoteOn events that came in also were followed by a NoteOff (for the same note that is).

I hope these additional details help to narrow the issue down. Unfortunately, I also have no access to a previous version that doesn't have that problem.

EDIT: I just checked out the sfizz-ui repository (and the sfizz submodule) at version 1.2.2 and built it manually, then tried the VST3 in Ardour 7.5.0 again and it worked - so I suppose it's a bug in 1.2.3 after all. I also used the Virtual Playing Orchestra for testing, by the way.

vertfin commented 3 months ago

+1, sfizz from AUR, version sfizz-1.2.3-2-x86_64, Reaper, Arch Linux. have not yet tried downgrading but will have to to complete current project.

vertfin commented 3 months ago

Can confirm downgrading to 1.2.2 fixes the issue.

SoliDeoGloria2 commented 3 months ago

Can confirm downgrading to 1.2.2 fixes the issue.

Hi! I'm not being able to install Sfizz 1.2.2 in Manjaro Linux with the source code (I'm probably doing something wrong). Trying to downgrade from 1.2.3 does not show the 1.2.2 version, either. How can I install 1.2.2 in Manjaro? Any tip will be appreciated, since the hanging notes make it difficult to work with Sfizz...

SoliDeoGloria2 commented 3 months ago

I've copied manually the usr folder files from a notebook of mine which has version 1.2.0 installed. I loose the latest fixes, but at least I don't have the hanging notes annoying me all the time. Anyway, I insist : the build instructions in Sfizz' home page are extremely opaque for the end user, to say the least. And we don 't have binaries for the previous releases, which is a problem in cases like this, when there is a serious bug. I hope this can be taken into account, since these kind of issues tend to make quite difficult the Sfizz experience, which in many other aspects is great.

vertfin commented 3 months ago

Can confirm downgrading to 1.2.2 fixes the issue.

Hi! I'm not being able to install Sfizz 1.2.2 in Manjaro Linux with the source code (I'm probably doing something wrong). Trying to downgrade from 1.2.3 does not show the 1.2.2 version, either. How can I install 1.2.2 in Manjaro? Any tip will be appreciated, since the hanging notes make it difficult to work with Sfizz...

I had to switch to clang to get it to compile. I don't know if that is expected. I ran:

export CC=/usr/bin/clang
export CXX=/usr/bin/clang++
cd build && cmake .. && make && sudo make install
SoliDeoGloria2 commented 3 months ago

Thank you very, very much, vertfin! That finally did it!! I had to pick the file from sfizz-ui, because I previously tried it with the library one by mistake, and I was wondering where were the plugin binaries!

kporkka commented 3 months ago

Would any of you be so kind and write just a bit more detailed instructions on how to compile the 1.2.2 and where to find the sources, Thanks!

bobobo-git commented 3 months ago

someone in the reaper Forum posted the way https://forum.cockos.com/showpost.php?p=2796429&postcount=14

i have the issue my self . win64 the vst3 and the lv2 (that i can run in REAPER when i get the controller.ttl from somewhere else) though im not too happy with the grafics . but that is another issue going to vst3 and the 1.2.2 for now.

SoliDeoGloria2 commented 3 months ago

someone in the reaper Forum posted the way https://forum.cockos.com/showpost.php?p=2796429&postcount=14

Yes, it was me. I'll transcribe it here and there is also a new issue I just opened with the same instructions.

1) You go to :

https://github.com/sfztools/sfizz-ui/releases

and download sfizz-1.2.2.tar.gz (or whatever version you need)

2) Extract the tar.gz file

You enter the directory of the extracted content and open a terminal right there (in Thunar or Nemo, right click and choose "Terminal" or "Open in terminal")

3) The usual method could be normally achieved by copying and pasting these instructions in the terminal (Ctrl-Shift+V inside the terminal) :

mkdir build && cd build && cmake .. && make && sudo make install

This is, in other words, the process described in the Build section of the Sfizz homepage. BUT, after a while in the process it could happen that, reaching a certain point, things get messed up. So, when you try it again you add these lines to switch to Clang (another compiler to build) :

export CC=/usr/bin/clang export CXX=/usr/bin/clang++ mkdir build && cd build && cmake .. && make && sudo make install

A side note : Manjaro, at least, has the clang and compiler-rt packages already installed. Those are the requisites for switching to Clang. If you have any problem while trying this procedure, check that they are installed in your system.

That did it for @vertfin, who kindly told me about it, and me . I don't know if it is a universal solution for the build issue, but it worked here in Manjaro.

kporkka commented 3 months ago

Thanks for the detailed instructions, which unfortunately did not work for me (on an Ubuntu clone 22.04), after trying all kinds of things for >hour. This should not be this difficult IMO. Perhaps the maintainers should wake up and fix the 1.2.3 version. image

SoliDeoGloria2 commented 3 months ago

Hmmm, sorry to read that it failed in your system... I agree with you that it shouldn't be that difficult to install Sfizz in Linux. The same .deb binaries that are available with each release could easily be put in the assets of each previous version. I've suggested that in the issue I opened today...

https://github.com/sfztools/sfizz-ui/issues/140

kporkka commented 3 months ago

Thanks for doing that, it would be a good solution.

And apologies to the devs, this is a great community project done at everyone's spare time, thanks for making this wonderful instrument.

SoliDeoGloria2 commented 3 months ago

Well, I can't contribute any tip to fix the issue (the devs will surely have something to say about it), but I could send you the files to install in an easy manner version 1.2.2 or even 1.2.0. Just tell me.

paulfd commented 3 months ago

Thanks everyone for reporting, and sorry for the annoyance. I can't promise anything but I'll try to get to what caused this regression. In the meantime, I'll see if I can enable older versions on OBS so you can revert back more easily, possibly.

SoliDeoGloria2 commented 3 months ago

Thanks so much for the reply, Paul! I think we're all in a similar situation regarding time, so it's comprehensible. Whenever you are able to add the older releases as binaries, it will be great! And regarding the build process, if it could be easier in any distro (for example, not having to apply tweaks like the switch to Clang to achieve it), it would also help a lot.

paulfd commented 2 weeks ago
  1. Is it one sfz file in particular or all/most of them?
  2. Does it happen when playing from the UI keyboard too?
JD-The-65th commented 2 weeks ago

For me, it happens when I use a variety of SFZ files, but it happens most often when I use the strings from Virtual Playing Orchestra, and the Standard and Metal guitars from Unreal Instruments.

It hasn't really happened when I use the UI keyboard but I personally don't use it often. The Hanging Notes also don't respond to MIDI panic, and I either have to disable and reenable the plugin, or change the amount of voices to silence them all.

SoliDeoGloria2 commented 1 week ago

Hi Paul!

Regarding the first question, it happened with all the SFZ files I used. I almost never use the UI keyboard, so I wouldn't be able to respond the second question. If you need our testing in that regard, I can do it one of these days.

Thanks for the support!

Greets.

El jue, 24 oct 2024 a la(s) 10:20 a.m., Paul Ferrand ( @.***) escribió:

  1. Is it one sfz file in particular or all/most of them?
  2. Does it happen when playing from the UI keyboard too?

— Reply to this email directly, view it on GitHub https://github.com/sfztools/sfizz-ui/issues/132#issuecomment-2435281393, or unsubscribe https://github.com/notifications/unsubscribe-auth/ACXFWVBTMPE6U76CY4ZCPJLZ5DX2VAVCNFSM6AAAAABEDA7UVCVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDIMZVGI4DCMZZGM . You are receiving this because you commented.Message ID: @.***>

paulfd commented 1 week ago

I had trouble making the bug appear with only the UI keyboard but looping some random midi clip did it. I found a potential culprit and fix in the envelope code, only to later realize I did touch this code since version 1.2.3 to include other fixes. Upgrading the library to the latest develop did seem to make it go away.

I pushed the upgrade on the develop branch, if anyone is willing to test. Builds should be mostly up to date on OBS too.

davidbragg commented 5 days ago

I'm unable to reproduce the problem in Reaper with the lv2 develop branch build. I've got a track with six instances that was getting stuck notes all over the place. I let it loop several times and no stuck notes.