search

sg-wireless / pymakr-atom

Adds a REPL console to Atom that connects to your Pycom board. It can run code on the board or synchronize your project files.
Other
35 stars 11 forks source link

postinstall fix #304

Closed jakobrosenberg closed 2 years ago

jakobrosenberg commented 2 years ago

Since we can't install serialport with apm, this fix adds npm install serialport in the package.json postinstall hook.

The "preinstall" fix worked when installed manually with

apm install
apm link

but didn't work when installed through the store. If apm doesn't use the pre and post hooks in package.json, this fix won't work either.

Unfortunately we don't know what the cause is for the incongruity between the store and the manual install, so trial and error seems like the best solution at the moment.

jakobrosenberg commented 2 years ago

If Atom doesn't use the posthook either, we can add a small script to the plugin that installs serialport. If that doesn't work either, we'll have to revert to v9.x.x which has compatibility issues and is unmaintained.

elmasria commented 2 years ago

@jakobrosenberg lets release this and see

jakobrosenberg commented 2 years ago

:tada: This PR is included in version 2.3.4 :tada:

The release is available on:

Your semantic-release bot :package::rocket: