sg-wireless / pymakr-vsc

GNU General Public License v3.0
97 stars 25 forks source link

Binary-refactor-deps-cleanup #156

Closed jakobrosenberg closed 2 years ago

jakobrosenberg commented 2 years ago

Same as binary-refactor but with removal of all unused dependencies.

Binaries are now built on extension activation.

Combined with the removal of unused dependencies the package has been shrunk from ~100mb to ~1mb.

Precompiling thoughts: It's possible to also precompile binaries for all known Electron / OS combinations, but I'm not sure there's anything gained and we risk package break whenever vscode is updated. Alternatively, we could do a hybrid and provide precompiled binaries and fallback to binary compilation, but the benefits are negligible.

Note on tests: I have only tested this on win and ubuntu. Both are able to start without the serialport error, but I'm unable to test the actual connection on ubuntu as I run it in WSL2 and I haven't solved USB passthrough yet.