sg-wireless / pymakr-vsc

GNU General Public License v3.0
97 stars 25 forks source link

default devicelist: add common USB Uarts #219

Closed Josverl closed 2 years ago

Josverl commented 2 years ago

add common serial devices and simplify devicelist defaults using regex

jakobrosenberg commented 2 years ago

Thanks @Josverl

I notice that 1a86 is missing. Is that a concern?

Josverl commented 2 years ago

I do not think that will be a concern as the 1a86 VendorID was added to support a TTGO board for which the driver does not provide a clear vendor ID #190 That VID is recorded to support the CH340 drivers as per https://devicehunt.com/view/type/usb/vendor/1A86 As there are quite a few different vendors that provide CH340 drivers, i think it makes sense to use the friendly name to identify the likely common device types. I now see that it makes sense to also include the CH341 "friendlyName=.*CH34[0|1|].*",

See below for a device list of some clone boards. Note: that in order to refresh the device list I need to restart the VSCode instance. I think the devicelist is not refreshed after it has been retrieved once.

I did not yet check that in detail as I tried remote extension debugging, https://code.visualstudio.com/api/advanced-topics/remote-extensions#debugging-using-ssh but that required the npm install which brings the gold old seriaport node gyph compilation issues :-(

path=COM6
manufacturer=Silicon Labs
serialNumber=018ADB6C
pnpId=USB\VID_10C4&PID_EA60\018ADB6C
locationId=Port_#0001.Hub_#0016
friendlyName=Silicon Labs CP210x USB to UART Bridge (COM6)
vendorId=10C4
productId=EA60

path=COM4
manufacturer=Silicon Labs
serialNumber=01C90AE7
pnpId=USB\VID_10C4&PID_EA60\01C90AE7
locationId=Port_#0003.Hub_#0016
friendlyName=Silicon Labs CP210x USB to UART Bridge (COM4)
vendorId=10C4
productId=EA60

path=COM12
manufacturer=wch.cn
serialNumber=9&eaa9200&0&2
pnpId=USB\VID_1A86&PID_7523\9&EAA9200&0&2
locationId=Port_#0002.Hub_#0016
friendlyName=USB-SERIAL CH340 (COM12)
vendorId=1A86
productId=7523
jakobrosenberg commented 2 years ago

Note: that in order to refresh the device list I need to restart the VSCode instance. I think the devicelist is not refreshed after it has been retrieved once.

We can fix that. :)

Merging this.

jakobrosenberg commented 2 years ago

:tada: This PR is included in version 2.8.7 :tada:

The release is available on:

Your semantic-release bot :package::rocket: