Closed Josverl closed 2 years ago
Love it!
Should the "what" precede the "where"?
Eg. should:
if (data instanceof Error) {
return data.stack || data.message;
}
be
// I'm leaning towards this one since the stack can be found in the developer console.
if (data instanceof Error) {
return data.message || data.stack;
}
or
if (data instanceof Error) {
return [data.message, data.stack].filter(Boolean).join('\r\n');
}
makes sense,
and I think it also makes sense to log the error to the log , but log all the details of the connection / failure using log.debug
so that can be hidden / revealed by changing the log level.
Yes, I've been meaning to revise the logging levels and coverage, but the priority hasn't been high so far.
:tada: This PR is included in version 2.8.7 :tada:
The release is available on:
Your semantic-release bot :package::rocket:
log
to allow for highlighting using any installed syntax highlighter for logs