Closed Josverl closed 2 years ago
Looks great. Are you able to rename the commit message to fix: change busy icon from lock to spinning sync
? The fix:
prefix will trigger semantic-release to push a new release.
Sure , rename is easy I was also considering possible use of either:
In both cases the status can be updated to show the filenames as they are uploaded / downloaded
that would give the nearly same progress functionality as V1, but using the VSCode API and UX rather than depending on terminal output
We're using notification withProgress for some actions, but I think it might be too intrusive for those running persistent scripts.
Also, I think we might be talking about different things. The busy state isn't restricted to just upload/download. It shows whenever a script is currently running. That said, to create a withProgress for download/upload would be straight forward.
OK , then please merge this as is. I've resolved the (version) conflicts
:tada: This PR is included in version 2.13.1 :tada:
The release is available on:
Your semantic-release bot :package::rocket:
Helps users to identify that something is in progress as mentioned in https://github.com/pycom/pymakr-vsc/issues/232
ref: https://code.visualstudio.com/api/references/icons-in-labels#animation