Closed Josverl closed 2 years ago
Just saw this. Love it.
Just to clarify, semantic-release
look at the commit messages, not the PR title, for writing the changelog and determining the next release version. To use the functionality, you can use the following prefixes:
device workspace [] after adding device to the workspace, reveal the folder in the navigation [] add navigation from device to folder in workspace ( as names are/can be very differently formatted)
Does this work with the VSCode restarts that happen whenever a workspace change from single to multi?
run a selection of code should run on last active device ( should be as easy as Python Shift-Enter)
Should there be a dedicated command for this, like run on active device
? Changing the behavior of the current action would be a breaking change and could also go against POLA if a script from project A is suddenly running on a device from project B.
I think one option for handling this could be to have n active device listed here
It would automatically update to the last used device, but if clicked, you could manually select a different device. An option to disable the automatic update might also be needed.
Alternatively we could also have a Pymakr view for this like we have for projects and devices. This could provide more flexibility in the long term.
Great job on this. Could we move the last two unfinished tasks to a separate PR and merge this one?
sure can punt/seperate the remaining actions to separate PRs, mostly using these points to keep track of things I'd like to solve or run into.
For this:
thanks for providing the prefixes, I had been looking for that but could not find them
My bad. I didn't think to mention them last time š
As for navigation on workspace creation, I don't think there's much we can do. If it's added as 1st or 2nd workspace it will trigger a restart, which we can't avoid. I really wish VSCode would show a notification that it restarted and the cause of it.
Anyway, worst case scenario, it won't auto reveal the folder if it's added as primary or second workspace. This could confuse some users about inconsistent behavior.
If we were to solve this, It's possible to open the device folder programmatically after the restart, but it would add complexity.
//pseudo code
const count = vscode.workspace.workspaceFolders?.length
// are we changing the primary workspace or changing to a multi workspace?
if (!count || count === 1) {
nextSession.tasks.push({
target: ['vscode', 'commands', 'executeCommand'],
params: ('revealInExplorer', uri)
})
}
Just a quick update, I'm currently working on the upload progress bar. š
Great job. I'll merge and push to next for a new release.
:tada: This PR is included in version 2.14.0 :tada:
The release is available on:
Your semantic-release bot :package::rocket:
After some trial and error, I just I had merged my local next-staging
into next
and not origin/next-staging
. Sorry for the delay :)
@Josverl I'm having a bit of confusion with this one: show device content in sidebar
. What does it add compared to the open device in file explorer
?
@jakobrosenberg Sorry for adding confusion ... perhaps the functionality should be merged
open device in file explorer
currently dos not actually open the device, but only adds the device to file explorer, and in the default layout does not show any visible change or result.
Also it also appears to only do something , when the device has not been added, and is a NOP on any future uses.
show device content in sidebar
.
Helps identify what device name is shown where in the file explorer. Needed as the device names in de different locations are not linked in any way: Pycom/device/mycustomname
--> files: serial://com32
I think it makes sense to merge these to Add/show device in Sidebar
or Add/show device in File Explorer
( Sidebar and File explorer seem to be both used by extension )
No probs. I think this is caused by slightly inconsistent behavior from SVCode. If a folder is not mounted, the mount command will mount it, but not select it. If it's already mounted, VSCode will select it instead.
If a folder is not mounted, the mount command will mount it, but not select it. If it's already mounted, VSCode will select it instead.
- the thing that it does not do is to change the focus to the 'Explorer View', and as the default config for PyMakr is to show the Devices in the
PyMakr view
I get what you mean, I'll see if I can consolidate the two commands.
I have a few improvements to the UX that I would like to propose. Most are based on my experience in trying to understand how to switch from Pymakr1 to Pymakr 2
get Pymakr instance (for extension development)
[Pymakr] Failed to run command: downloadProject. Reason: Cannot read properties of undefined (reading 'device'). Please see logs for info.