search

sg-wireless / pymakr-vsc

GNU General Public License v3.0
97 stars 25 forks source link

Root path #243

Closed jakobrosenberg closed 2 years ago

jakobrosenberg commented 2 years ago

This PR auto detects the root path of devices, Pycom and third party.

I'm not a fan of using VSCode's workspaceState for this.

workspace global
config WorkspaceConfiguration.update('field', value) WorkspaceConfiguration.update('field', value, true)
state ExtensionContext.workspaceState ExtensionContext.globalState

Currently we use workspaceState for managing devices, but as the project grows, this could prove counter productive. If we switch to using configs rather than state, we may have greater control over which level (workspace vs global) at which we store data. This is predicated on workspace + global configs deep merging on retrieval. This is likely not the case, but is worth investigating.

At any rate, it might be time to consider a more flexible approach to storing state / config.

jakobrosenberg commented 2 years ago

@Josverl have you got any thoughts on this? I'm tempted to merge it and save the config/state refactoring for a separate PR.

sgwireless-bot commented 2 years ago

Task linked: CU-2v7nr6r Better handling of non-Pycom devices

jakobrosenberg commented 2 years ago

Closed in favor of https://github.com/pycom/pymakr-vsc/pull/251