search

sg-wireless / pymakr-vsc

GNU General Public License v3.0
97 stars 25 forks source link

[BUG] Upload prompt won't finish #289

Open Leo5126 opened 1 year ago

Leo5126 commented 1 year ago

Describe the bug When trying to upload a file, the upload prompt will open and it also starts uploading. The problem is, that the window won't close, and the communication with the device is also blocked. To have access on the device again a restart of VSC is required. The interesting thing is, altough it doesn't look like the upload worked, the file is uploaded correctly when i recheck it after a restart. Is this a known issue?

To Reproduce in my case this error occurs every time i try to upload a file by right clicking on file and then upload to device.

Expected behavior A clear and concise description of what you expected to happen.

Screenshots image image

Desktop:

daniel-da commented 1 year ago

Hi Leo,

It may be a known issue, can you try the fix I've made in this PR?

https://github.com/jakobrosenberg/micropython-ctl/pull/2

Leo5126 commented 1 year ago

Hi @daniel-da,

Thanks for the tip. But I don't quite understand how to test this other repo together with the extension. How did you do this?

daniel-da commented 1 year ago

Hi @Leo5126 ,

First you get the file content from the PR. This is the direct link: https://raw.githubusercontent.com/jakobrosenberg/micropython-ctl/40121187cd12b242eab2eb7c36c196c9a87b4064/src/main.ts

Then copy it into the extention folder, I'm on linux so it is here for me: /home/dany/.vscode/extensions/pycom.pymakr-2.22.5/node_modules/micropython-ctl-cont/src

Hope that will fix you issue

Leo5126 commented 1 year ago

Hi daniel,

Unfortunately this doesn't work for me. I get a new error when trying to upload:

image

You know this error? Do I need to deactivate any auto update or smth similar?

I've changed the file for the preview version of pymakr plugin 2.22.5

hsand commented 1 year ago

I'm experiencing similar issues on Ubuntu with the ESP32S3 as well. I tried the pull request @daniel-da mentioned above, didn't get any errors as @Leo5126 did, but it also didn't fix the issue.

I'm wondering if this is somehow related to the S3 variant of the ESP32.

Edit: Tested the same setup with an old ESP8266 I had laying around and it worked perfectly. Seems to be related to the board itself.

sausthapit commented 1 year ago

Hi daniel,

Unfortunately this doesn't work for me. I get a new error when trying to upload:

image

You know this error? Do I need to deactivate any auto update or smth similar?

I've changed the file for the preview version of pymakr plugin 2.22.5

Hi new to Pycom, the upload doesn't work for me either. I am using MacOs and LoPy4 with Pysense. Same error as shown in the picture. Did you manage to solve it?

miguelcostaUI commented 1 year ago

I also can't upload any code. It just says that it is uploading forever and nothing happens. Tried the normal version (v2.22.5) and the preview version (v2.25.2) and nothing is uploaded. macOS 12.6.3 - VS Code Version: 1.76.2

Did you find any way to fix this?

fsouterelle commented 4 months ago

Hello. Same comment as @hsand : I tried the PR and it did not fix the issue. I don't have any issue with ESP32-WROOM and ESP32-WROVER, but I always reproduce the problem with ESP32-S3

Edit : actually it seems to work correctly when I use the "USB" port of my esp32-S3-DevKitC instead of the UART one