GBP Symbol doesn't update when currency is changed

sg3-141-592 / AzStartStop

Self service user interface for starting and stopping VMs on demand

https://vmstartstopdemo.compactcloud.co.uk/

MIT License

22 stars 2 forks source link

GBP Symbol doesn't update when currency is changed #3

Closed JClarke90 closed 1 year ago

JClarke90 commented 1 year ago

Sorry I promise I'll not post too many things, but I really like the tool, just what I've been looking for.

Hopefully a quick fix, when you select the currency the table updates but the total still shows the GBP symbol instead of the selected currency. But at least the amount is correct so not a big issue.

sg3-141-592 commented 1 year ago

Hey @JClarke90 no worries, feel free to raise anything that isn't working or would make it even more useful for you. Good spot, so on this table there's a little bit more work to do.

VM Spend - last month - at the moment the currency for this value is based on the first billing currency for a VM we see in your subscription. For example we use GBP on this bill

VM Spend - est next month - this should be in the currency users have selected in the background. I'll include it in a future release.

JClarke90 commented 1 year ago

Ah interesting, makes sense as I’m just testing this on my msdn subscription so don’t really do much with the billing side.

Will be testing it out in a dev environment this week so it should be correct in there.

Feel free to close this if it’s working as expected.

sg3-141-592 commented 1 year ago

Fix has been pushed in #10 . Currency you select in settings is now used in your estimate.