search

sgaraud / gnome-extension-show-ip

gnome shell extension showing ip in status bar
GNU General Public License v3.0
42 stars 17 forks source link

Add option to place in network menu #17

Closed paddatrapper closed 7 years ago

paddatrapper commented 7 years ago

Adds the option for the IP address label to be placed in the network menu instead of the top bar.

This is achieved through two parent classes, each which inherit from their respective GNOME UI base classes. These parent classes contain an instance of the base class, which does the work in manipulating and retrieving the IP address.

sgaraud commented 7 years ago

thank you for that change! I will check it asap and make a new release including it.

paddatrapper commented 7 years ago

@sgaraud any chance to review this?

sgaraud commented 7 years ago

thanks for your contribution. I really appreciate it. I added the french localization. The change will be included in the next update on gnome extension website. I may change the IP: display in the final v7 as I got some requests to display the interface name.

paddatrapper commented 7 years ago

Anytime. This merge means that from the v7, ShowIP will be packaged for Debian Sid and Buster (next but one stable release)

On 15 Apr 2017, 14:20, at 14:20, sylvain garaud notifications@github.com wrote:

thanks for your contribution. I really appreciate it. I added the french localization. The change will be included in the next update on gnome extension website. I may change the IP: display in the final v7 as I got some requests to display the interface name.

-- You are receiving this because you authored the thread. Reply to this email directly or view it on GitHub: https://github.com/sgaraud/gnome-extension-show-ip/pull/17#issuecomment-294289969