nesquena
commented
11 years ago :+1: Looks great Shantanu, a few points of feedback:
- Used FrameLayout to act as a container for timeline tab content
- Setup ActionBar Tabs mode with the Home and Mentions timeline tabs
- Should checkout tabs cliffnotes to see how you might do this in a Gingerbread compatible way and using a "FragmentTabListener" which is recommended approach by Google.
- Setup the base fragment class that the timelines all extend from
- Setup home timeline fragment without much unnecessary code duplication
- Setup mentions timeline fragment without much unnecessary code duplication
- Setup endless pagination that works across home and profile timelines
- Properly setup user profile view with profile header and a user timeline fragment
- Can view my profile by clicking on the ActionBar
- Clicking on a users profile image takes me to their profile
- Compose works and refreshes the home timeline properly
- OPTIONAL: Right now if I click on a friend's profile and then click on their image again in their profile, it opens up a second profile. This sort of profile recursion is kind of odd from the UI perspective, real twitter client disallows stacking up navigation to the same user's profile over and over
Great work on the project, hopefully you can see this coming together as a "fully fledged" twitter client with some more work and polish. This app contains all of the components now (fragments, models, networking, client, tab navigation, image loading, et al) of 90% of dynamic data-driven API client. Obviously there are lots of details and patterns to learn, but by this point you have been introduced to all the major frameworks and concepts. Hopefully you would feel fairly confident getting started making Android apps for instagram, pinterest, yardsale, flickr,
Today (Week 5), we are going to cover the last major piece to the Android puzzle and that is using the hardware and SDK components such as the camera, photo gallery, location, maps, etc. After that, Week 6 we will be covering all the topics that separate an intermediate Android developer from a beginner that will act things you should start reviewing to continue your path to being a great Android developer.
Week 7 (Sept 30th), we are going to have a demo day to celebrate the progress you've all made with our next batch of Android students and multiple companies attending to see the group apps that you all have built. We are going to help however we can over the next 2 weeks to get the apps in shape and also have you all prepare a short slide presentation as well.
My app is a complete, please review. /cc @nesquena @timothy1ee.
All implemented user stories are documented in the README.md