Guidance for monorepos - Githubissues

sgb-io / codehawk-cli

Codehawk is a static analysis tool for JavaScript projects.

MIT License

50 stars 4 forks source link

Guidance for monorepos #108

Closed sgb-io closed 1 year ago

sgb-io commented 2 years ago

Should the tool be used at the root or by individual packages? My gut is the root.
Are child node_modules ignored by default? I don't think so, but it should be changed to detect yarn workspaces by default
Generally, should options that contain paths support wildcard paths? e.g. packages/**/src. My gut feel is that, yes, this should work.

sgb-io commented 2 years ago

There is an issue with monorepos for the current implementation: it is assumed that a single coverage dir exists

sgb-io commented 2 years ago

Update: codehawk-cli works for monorepo projects, but it needs to be installed per-package with a codehawk.json and codehawk src script for each package. This is workable but not ideal. It's probably worth updating the docs to state this whilst support for a single config + script in a monorepo root is worked out.

sgb-io commented 1 year ago

Closing due to https://github.com/sgb-io/codehawk-cli/issues/122