search

sgenoud / replicad

The library to build browser based 3D models with code.
https://replicad.xyz
MIT License
324 stars 38 forks source link

Fix TypeScript signature of the emscripten module init function #55

Closed jirihon closed 3 months ago

jirihon commented 1 year ago

This fixes TypeScript problem described in issue #54.

The pach adds the missing argument to the init function. For simplicity, the type of the argument is set to any. Exact type could be imported from @types/emscripten. However, introducing new dependency is a serious thing, so I leave the decision to the maintainers of this awesome package.

netlify[bot] commented 1 year ago

Deploy Preview for stupefied-edison-1dae54 canceled.

Name Link
Latest commit bed50d8825c5befd25ceeb6e444a9c540068b362
Latest deploy log https://app.netlify.com/sites/stupefied-edison-1dae54/deploys/62e38abbf386a00008e8aa87
github-actions[bot] commented 1 year ago

CLA Assistant Lite bot All contributors have signed the CLA ✍️ ✅

jirihon commented 1 year ago

I have read the CLA Document and I hereby sign the CLA

sgenoud commented 1 year ago

This function is generated automatically with opencascadejs - so your commit will be overridden the next time I generate them.

I should update the version I use to generate the bindings (and it should solve it).