search

sgenoud / replicad

The library to build browser based 3D models with code.
https://replicad.xyz
MIT License
323 stars 38 forks source link

compressing all the images #78

Closed origamifreak2 closed 1 year ago

origamifreak2 commented 1 year ago

Passed all the images through some compression software https://imageoptim.com/mac . The quality of the images should not be affected.

netlify[bot] commented 1 year ago

Deploy Preview for stupefied-edison-1dae54 canceled.

Name Link
Latest commit 99dd2a482731a6747da117906490f55da12e26d0
Latest deploy log https://app.netlify.com/sites/stupefied-edison-1dae54/deploys/6454789197f3b7000808b3c1
github-actions[bot] commented 1 year ago

CLA Assistant Lite bot All contributors have signed the CLA ✍️ ✅

origamifreak2 commented 1 year ago

I have read the CLA Document and I hereby sign the CLA

origamifreak2 commented 1 year ago

recheck

origamifreak2 commented 1 year ago

recheck

sgenoud commented 1 year ago

Thanks for the PR! I will look into fixing this CLA bot. This is a PITA.

Nevertheless I have an additional request. You have compressed all the images - even the ones in the tests (which should be kept as is). You would mind reverting this part of the PR (I can also do it myself).

origamifreak2 commented 1 year ago

@sgenoud No problem, I've reverted all the images in the tests folder.

origamifreak2 commented 1 year ago

recheck

sgenoud commented 1 year ago

Did you try to rebase main (I hope it helps with the CLA issue, it is a pain, sorry)

origamifreak2 commented 1 year ago

I have read the CLA Document and I hereby sign the CLA

origamifreak2 commented 1 year ago

Did you try to rebase main (I hope it helps with the CLA issue, it is a pain, sorry)

Just to make sure, do you mean rebase my main branch to the second commit of my image compression branch?

origamifreak2 commented 1 year ago

I have read the CLA Document and I hereby sign the CLA

sgenoud commented 1 year ago

After some investigation into why the CLA checks was not working I think I have found the issue.

I think that the email you used with git itself is not registered as one of your emails for @origamifreak2, but for another github account @camden-bassett . Could you merge your accounts, or sign with the @camden-bassett account?

Sorry for these complications!

origamifreak2 commented 1 year ago

recheck

origamifreak2 commented 1 year ago

After some investigation into why the CLA checks was not working I think I have found the issue.

I think that the email you used with git itself is not registered as one of your emails for @origamifreak2, but for another github account @camden-bassett . Could you merge your accounts, or sign with the @camden-bassett account?

Sorry for these complications!

My fault. Didn't remember I had set up a git account under my work email as well. Merging the accounts fixed the error.