sggreener / GeoRaptor

GeoRaptor Repository
MIT License
7 stars 3 forks source link

Bugfix/issue 5 libs #6

Closed PhilippSalvisberg closed 4 years ago

PhilippSalvisberg commented 4 years ago

Fixes #5 - libraries missing in SQL Developer

Copy to clipboard -> Selected geometries works. Copy to clipboard -> MBR of selected geometries causes a NoSuchElementException. This is an application error and has nothing to do with missing libraries.

PhilippSalvisberg commented 4 years ago

I'm looking at the conflicts...

PhilippSalvisberg commented 4 years ago

I've resolved the conflicts.

I've seen that you changed the path to SQL Developer for Windows

https://github.com/sggreener/GeoRaptor/blob/master/pom.xml#L24

That's ok. It has primarily to match your environment. I've changed the path for macOS to match mine. I hope that's ok.

sggreener commented 4 years ago

Happy with the macOS settings to reflect your environment.

JGeometry needs physical connection, unwrap proxy connection add library/extension for ProxyRegistry

I would like to understand this some more after the current extension build is completed.

read xBaseJMicro.jar from new location

I noted, yesterday, that this jar was not in Maven Central but its "fuller" version read xBaseJ.jar which is why I attempted to add it to pom.xml. I am happy to use either. I've always used xBaseJMicro.jar, can't recall why, but I have had to alter the source and build it from that. The xBaseJ project is quite old (as befits the age of dBase).

ensure that the JARs for sdoapi and sdoutl are copied to the resulting artefact

Does this mean GeoRaptor will pick up the SQL Developer versions?

sggreener commented 4 years ago

After I merged the pull requests, I still get the attached in TortoiseGit on Pull.

I guess I expected only Master.

2020-05-18_09-55

PhilippSalvisberg commented 4 years ago

A merge of a PR does not delete the branch automatically. You can press on the "Delete branch" to do so. I've done that for PR #2 and #4.