sghall / react-move

React Move | Beautiful, data-driven animations for React
https://react-move-docs.netlify.app
MIT License
6.58k stars 168 forks source link

final pass for NodeGroup #55

Closed dagda1 closed 5 years ago

dagda1 commented 5 years ago

I'm just going to leave this here. Delete it, bin it or you might find something useful.

The reason I started doing this is because this is what I saw in my console when I upgraded react-move@l5.2.

react-move

I was trying to fix these with a very limited view of the project before being told I was running round in circles etc. and not using every use case known to react-move.

I no longer see these errors for my admittedly narrow use case.

I do think the typing is broke and should be fixed but if no one else is complaining then maybe not many are using ts which is totally fine.

These types work for my use case, namespaces and all.

There won't be any more conversation but this might at least end on a somewhat useful note.