search

sghiassy / react-native-sglistview

SGListView is a memory minded implementation of React Native's ListView
MIT License
743 stars 72 forks source link

scrollRenderAheadDistance, stickyHeaderIndices #28

Open pesterhazy opened 8 years ago

pesterhazy commented 8 years ago

With RN 0.30.0, warnings appear about the two props mentioned in the title:

 <Warning>: Warning: Failed prop type: Required prop `stickyHeaderIndices` was not specified in `SGListView`.

It's easy to get rid of the warnings by adding the default values (1000 and [], respectively).

This is the relevant bit in the RN code: https://github.com/facebook/react-native/blob/975d196c67dfbe657e9027eb96c9d6ab218c9f17/Libraries/CustomComponents/ListView/ListView.js#L247-L256

Ideally these should not be required props for SGListView as they have default values in the ListView code.

Thanks for the life-saving module!

chandlervdw commented 8 years ago

In addition, how are you supposed to use premptiveLoading if it can conflict with scrollRenderAheadDistance?

sghiassy commented 8 years ago

@pesterhazy - Any chance you have time to submit a PR that uses those constants in SGListView? I'm super booked unfortunately.