sghiassy / react-native-sglistview

SGListView is a memory minded implementation of React Native's ListView
MIT License
743 stars 72 forks source link

Rendering bug when using sectionHeaders #41

Open mschipperheyn opened 7 years ago

mschipperheyn commented 7 years ago

I have a rendering bug that doesn't occur with the normal ListView. It occurs when I use section Headers.

After some scrolling, the items start overlapping each other. I'm assuming that the trick with emptying out invisible boxes is not taking sections into consideration.

screen shot 2016-10-17 at 17 31 59 screen shot 2016-10-17 at 17 31 48

I call SGListView like so

  <SGListView
      ref="sglist"
      automaticallyAdjustContentInsets={false}
      dataSource={this.state.ds}
      renderRow={renderRow}
      contentContainerStyle={this.props.contentContainerStyle}
      stickyHeaderIndices={[]}
      initialListSize={this.props.initialListSize}
      scrollRenderAheadDistance={1}
      pageSize={12}
      scrollEnabled={scrollEnabled}
      onScroll={onScroll}
      scrollEventThrottle={0}
      onMomentumScrollEnd = {onScrollEnd}
      onEndReached={this.handleLoadMore}
      onEndReachedThreshold={70}
      renderSectionHeader={this.props.renderSectionHeader}
      renderFooter={this.renderFooter}
      contentContainerStyle={[localStyle.container,contentContainerStyle]}
      onLayout={this.setListHeight}
      refreshControl={
        <RefreshControl
          refreshing={showRefresh}
          onRefresh={onRefresh}
        />
      }
  />
sghiassy commented 7 years ago

Can you verify that using a regular ListView produces the right UI? Thanks.

sghiassy commented 7 years ago

haha... totally missed your first sentence.

So yeah, this seems like a total bug. Many apologies, but I don't know how I'll have time to tackle it in the short-term.

PRs are greatly appreciated.

Cheers, -- Shaheen

mschipperheyn commented 7 years ago

my renderRow method doesn't use sectionId. I'll investigate if this could be the issue. Also, I resort data when new data comes in load-more style. Wonder if this screws with section references somehow.

vivekguptaraw commented 7 years ago

hi @mschipperheyn , have you found solution for the bug related to section header ? Please let me know if possible. Thanks

sghiassy commented 7 years ago

There was an update to the section headers logic in the newest release. Try updating to version 0.4.3