sghpjuikit / player

Audio player and management application.
22 stars 2 forks source link

Clean up gradle build files #139

Closed sghpjuikit closed 5 years ago

sghpjuikit commented 5 years ago

This is umbrella issue for all gradle-project-structure things.

1 Having gradle build files in one location is against convention. Do we move build files? Where?

2 The first improvement I suggest is to create a player subproject to let the root project encapsulate the entire project and nothing else. Right now project.gradle.kts fulfills 2 roles. So:

xeruf commented 5 years ago

Please do not call it "root" but "player", root is ambiguous as we.

sghpjuikit commented 5 years ago

Blocked by creating buildSrc build, which will split off utility portion of the builds into standalone build, where custom tasks will also reside.

sghpjuikit commented 5 years ago

I attempted to split the build file but failed to work it out. I'm putting this off for now. Very low priority.

xeruf commented 5 years ago

Yeah, things like these are what I do when I get bored, so I'd assign this to me and do it sometime 😉

sghpjuikit commented 5 years ago

Thx

sghpjuikit commented 5 years ago

I realized you have put certain tasks (buil, run, ...) into a main group. Is there any reason for this other than covnenience?

My real question however is that assuming we split the main build file into that for allprojects and main module, which module should have application plugin and the run task?

xeruf commented 5 years ago

I realized you have put certain tasks (buil, run, ...) into a main group. Is there any reason for this other than covnenience?

No, only for convenience, so that you can directly find the most important task in the IDE.

My real question however is that assuming we split the main build file into that for allprojects and main module, which module should have application plugin and the run task?

I would put the run task into the root file, or have it in the player and then add a run task to the root that delegates to the player, kind of a taste thing.

sghpjuikit commented 5 years ago

I see. So I was on the right track, just lacked the skill to finish through.

sghpjuikit commented 5 years ago

kotlinc task that downloads kotlin compiler is now removed. This is handled in runtime by the application itself. See #174

sghpjuikit commented 5 years ago

Closing as non-issue. Any improvements in build will be done when needed.

sghpjuikit commented 5 years ago

I used idea gradle plugin to set up out as an excluded directory for widget modules. This solves some of the IDE warnings, like class already declared.