search

sghpjuikit / player

Audio player and management application.
22 stars 2 forks source link

Use base64 for composed audio-tag fields to avoid delimiters #160

Closed sghpjuikit closed 4 years ago

sghpjuikit commented 5 years ago

Currently, we compose few custom fields together. There is also CHAPTERS, which is a List value. These things must be safe to use with any string values and not just use arbitrary delimiters.

Encoding the values will definitely solve the issue, though at the cost of making the values longer, which may be a problem depending on audio tag value length support. So this needs to be checked. And it will also not produce human readable values. It may also make tag writing/reading take longer.

This needs to be fixed before release to prevent migrating. The final solution needs to be exactly that: final.

sghpjuikit commented 4 years ago

I decided against this. There is an assert preventing user to insert text containin a delimiter character. The delimiters are also special characters in the ascii table (29, 30, 31), however, because they are invisible it could cause issue when inspecting the tag in external program. However I believe readability comes first - seeing base64 in an external program would be even worse...

So, Im closing this.