search

sghpjuikit / player

Audio player and management application.
22 stars 2 forks source link

Player becomes uncontrollable when playlist contains only unplayable items #35

Closed xeruf closed 5 years ago

xeruf commented 6 years ago

When the playlist contents can't be played for whatever reason (in this case because vlc isn't present), then the player indefinitely cycles through all the Songs and is not stoppable. The only option is closing it.

A simple and good solution would be to add a one second delay before skipping an unplayable item, therefore the user has time to realise what is wrong.

log_contents.log

sghpjuikit commented 6 years ago

There is a mechanism to prevent this, however when VLC is not present, it is bypassed. Known issue. It isnt difficult but there may be better and worse ways to go about handling this.

sghpjuikit commented 5 years ago

Fixed 8b21efa34b2798a2bf29a19ba812f2405562daf1

As mentioned there are two reasons for being unable to play a song: invalid song or problem with the underlying player (javafx/vlc). The former is properly defended against. The latter has two situations: unable to play current song or unable to play any song at all. This determines whether we attempt to play next song in line.