search

sghpjuikit / player

Audio player and management application.
22 stars 2 forks source link

Settings safe mode #62

Closed xeruf closed 6 years ago

xeruf commented 6 years ago

Sometimes when changing settings, weird issues occur (like #57). So I would like to have a little toggle somewhere in the Settings, something like "safe mode", which will only apply the changes with the next startup. This would at least be a first workaround to the aforementioned bug, since the only alternative right now is to edit the application.properties manually.

Of course this is no solution, but it's a neccessary fallback for unexpected errors.

sghpjuikit commented 6 years ago

I don't view this as a satisfactory fix for anything, not even temporarily. If there are issues, they need to be fixed. This requested feature would only pose additional complexity (for something to go wrong) without any merit.

xeruf commented 6 years ago

Sometimes, it is actually useful to have a setting change only after restart. Additionally, imagine a user finding an issue like this, and we obviously need a few days to tackle it - I think this would be a valid workaround for the time being then.

sghpjuikit commented 6 years ago

Not every setting actually changes immediatelly (depends on whether they are observable). It would be easier to mark those that require restart and highlight this in ui. This is trying to work around issues that happen when settings change, but these are just ordinary bugs like anywhere else. I see no reasons to adjust part of application out of an expectation for a bug.