search

sgibb / MALDIquant

Quantitative Analysis of Mass Spectrometry Data
https://strimmerlab.github.io/software/maldiquant/
60 stars 25 forks source link

Weighted moving average #54

Closed SiggiSmara closed 6 years ago

SiggiSmara commented 6 years ago

Preemptively creating the pull request for the weighted moving average. More explanation in #53

codecov[bot] commented 6 years ago

Codecov Report

Merging #54 into master will increase coverage by 0.03%. The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #54      +/-   ##
==========================================
+ Coverage   88.65%   88.68%   +0.03%     
==========================================
  Files          80       80              
  Lines        1613     1618       +5     
==========================================
+ Hits         1430     1435       +5     
  Misses        183      183
Impacted Files Coverage Δ
R/smoothingFilters-functions.R 100% <100%> (ø) :arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update cce5c67...063c32e. Read the comment docs.

SiggiSmara commented 6 years ago

No problem with the coding style. I shall try to be more careful in the future. I think your suggestion of incorporating the weights into the MovingAverage is a very good one. This also lessens the changes to be added to packages that rely on this function. I've made the changes, also to the unit tests and man pages.

sgibb commented 6 years ago

Thanks a lot! I will run a few checks and tests and submit to CRAN soon.