search

sgigou / NoveFeatherIcons

Feather Icons for your Swift projects.
MIT License
2 stars 1 forks source link

Swift Package Manager Support #1

Open neilpoulin opened 4 years ago

neilpoulin commented 4 years ago

First of all, thanks for the great icon library! It's really saved me a lot of time. We were already using Feather Icons, but my designer would make .pfd versions fo the icons I needed, and I'd add them to my asset catalog manually. This was kinda painful. Now, I have access to all the icons via NoveFeatherIcons!

I'm trying to move as many dependencies to Swift Package Manager as I can, and I'd love to move this one if possible.

If I get a chance, I'll look into making a PR, but I haven't created an SPM package before, so not sure what the learning curve will be.

sgigou commented 4 years ago

I'm glad this pod helped you!

Porting it to SPM is a really good idea, but I never created it neither. Let's hope pod and package can be combined in a single project with multiple targets (for example).

If you have some time to spend, it would be awesome, and I'll be pleased to integrate your code (and discover how it works)! If not, then no problem: I will add it to my todo list and work on it as soon as I can.

Thanks for the issue anyway.

neilpoulin commented 4 years ago

I've been trying to get a Swift Package created, and I am nearly there. However, I ran into an issue where Swift Tools version 5.2 doesn't support bundling resources -- it only allows for source code (.swift files). That means that you can not include an asset catalog or other types of resource files.

This has been added In swift-tools 5.3, which is included in XCode 12, but it's still in Beta.

I'll commit my fork to GitHub, but I'll probably table this until XCode 12 is out of Beta.