Needs port to lablgtk3 - Githubissues

sgimenez / laby

Learn programming, playing with ants and spider webs ;-)

https://sgimenez.github.io/laby/

Other

99 stars 39 forks source link

Needs port to lablgtk3 #60

Open glondu opened 4 years ago

glondu commented 4 years ago

gtksourceview2 is deprecated and has been unmaintained for a long time (at least 3.5 years). It will soon be removed from Debian. Meanwhile, lablgtk3 has been released, with bindings to gtksourceview3. IMHO, it's time to port laby to lablgtk3.

sgimenez commented 4 years ago

Hi Stéphane.

Sorry for the delay. I haven't contributed anything here for years now, and just happened to notice your message by chance. I've tried to get up to date on the OCaml stuff. I already have some changes that I will commit soon. I still have to figure out how to do the menu items correctly. All the rest seems fine on lablgtk3 and lablgtksourceview3 with just minor modifications.

I'd be happy if someone else could test them. I'll try to go through the other pending pull requests and issues, and hopefully tag a new release soon.

sgimenez commented 4 years ago

It seems that two issues remain in order to port laby to lablgtk3:

The GMenu.image_menu_item interface (which existed in lablgtk2) seems to be missing in lablgtk3 (although it appears to still exist in gtk3). It means that we can't use the stock menu items that have pretty icons and, more importantly, are already translated.
The "pixmap"s are gone. Laby was relying on them to stack images on a tile. GdkPixbuf.copy_area works differently. It appears that it overwrites opaque pixels with transparent ones. We may have to do that kind of image processing in Ocaml, by accessing the raw pixels, but I wish we could avoid it.

glondu commented 4 years ago

I'd be happy if someone else could test them.

I've tested master and it seems to work mostly. The only annoying thing is the ant disappearing when it carries a rock (a problem with transparency, I guess, related to your comment on pixmaps gnoe).

sgimenez commented 4 years ago

I figured out that GdkPixbuf.composite does the job even though we do not need scaling. So the only remaining issue is the missing translation in the menu items. I guess we can make a new release and wait to see if the image_menu_items are added back to lablgtk3.