search

sgjsakura / AspNetCore

ASP.NET Core Extension Library
Apache License 2.0
162 stars 26 forks source link

Migrated to ASP.NET Core 2.0, ExternalCookie project not included #28

Closed peterpauldewit closed 7 years ago

peterpauldewit commented 7 years ago

Pretty new to Github in general, but as the title says: I've migrated all projects except 'Sakura.AspNetCore.Authentication.ExternalCookie' to Core 2.0. Said project has some breaking changes for Core 2.0 for which I couldn't find a quick solution.

sgjsakura commented 7 years ago

HI, thank you for you help. Actually, .NET Standard 2 are down-side compatible and all the nugget package designed for .NET Standard 1.x can be used in .NET Standard 2 applications, and only codes with breaking change should be carefully redesigned.

To maximize the application runtime version support, I've kept most packages unchanged, while the Sakura.AspNetCore.Authentication.ExternalCookies and Sakura.AspNetCore.Mvc.TagHelpers packages has been updated in order to work correctly in .NET Standard 2 applications (including any .NET Core App 2 framework applications). You may download the newest packages from nuget.org.

Thank you again for your code review and you are welcome to help me test and improve the library code. If there's any further problem, just feel free to reply or create new issue. :-)