search

sgjsakura / AspNetCore

ASP.NET Core Extension Library
Apache License 2.0
162 stars 26 forks source link

[Documentation] Localization needed for taghelpers #29

Closed peterpauldewit closed 6 years ago

peterpauldewit commented 6 years ago

I guess it's been around since you fixed the language issue on the select taghelpers, but those wanting to use the select taghelpers without having localization anywhere else will have to add that in their startup file.

Since I don't consider that intuïtive I'm proposing to add it in the docs somewhere that you need to add the "services.AddLocalization();" in order for the taghelpers to work.

sgjsakura commented 6 years ago

Hi, thank you for your feedback. This problem is caused by the dependency injection usage of services during the initialization the tag helpers. I will try to remove the strong dependency for optional services and this bug should be fixed in the next release.

sgjsakura commented 6 years ago

Hi, this bug has been fixed in the tag helper library of version 1.3.7. I'm closing this issue and please feel free to reopen it if you have any new problem.