sgkit-dev / bio2zarr

Convert bioinformatics file formats to Zarr
Apache License 2.0
28 stars 7 forks source link

Bug in dexplode-partition #241

Closed jeromekelleher closed 5 months ago

jeromekelleher commented 5 months ago

Not sure how this got through testing:

jk@empire$ vcf2zarr dexplode-init sample.vcf.gz sample-dist.icf/ 5
Do you want to overwrite sample-dist.icf? (use --force to skip this check) [y/N]: y
    Scan: 100%|█████████████████████████████████████████████████████████████████████████████████████████████████████████████████████████████████████████████████████████████████████████████████████████| 1.00/1.00 [00:00<00:00, 4.11files/s]
num_partitions  3
num_samples     3
num_variants    9
jk@empire$ vcf2zarr dexplode-partition sample-dist.icf 0
Traceback (most recent call last):
  File "/home/jk/.local/bin/vcf2zarr", line 8, in <module>
    sys.exit(vcf2zarr_main())
  File "/home/jk/.local/lib/python3.10/site-packages/click/core.py", line 1157, in __call__
    return self.main(*args, **kwargs)
  File "/home/jk/.local/lib/python3.10/site-packages/click/core.py", line 1078, in main
    rv = self.invoke(ctx)
  File "/home/jk/.local/lib/python3.10/site-packages/click/core.py", line 1688, in invoke
    return _process_result(sub_ctx.command.invoke(sub_ctx))
  File "/home/jk/.local/lib/python3.10/site-packages/click/core.py", line 1434, in invoke
    return ctx.invoke(self.callback, **ctx.params)
  File "/home/jk/.local/lib/python3.10/site-packages/click/core.py", line 783, in invoke
    return __callback(*args, **kwargs)
  File "/home/jk/.local/lib/python3.10/site-packages/bio2zarr/cli.py", line 267, in dexplode_partition
    vcf2zarr.explode_partition(icf_path, partition)
  File "/home/jk/.local/lib/python3.10/site-packages/bio2zarr/vcf2zarr/icf.py", line 1216, in explode_partition
    writer.explode_partition(partition)
  File "/home/jk/.local/lib/python3.10/site-packages/bio2zarr/vcf2zarr/icf.py", line 1136, in explode_partition
    self.process_partition(partition)
  File "/home/jk/.local/lib/python3.10/site-packages/bio2zarr/vcf2zarr/icf.py", line 1088, in process_partition
    core.update_progress(1)
  File "/home/jk/.local/lib/python3.10/site-packages/bio2zarr/core.py", line 210, in update_progress
    with _progress_counter.get_lock():
AttributeError: 'NoneType' object has no attribute 'get_lock'